Expose all params for AddHoldInvoice
#204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
Dec 12, 2024
GeorgeTsagk
force-pushed
the
addholdinvoice-params
branch
from
621b93b to
7bc9c22
Compare
GeorgeTsagk
force-pushed
the
addholdinvoice-params
branch
from
7bc9c22 to
8f9bf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we'd only pass through a very limited set of the parameters to the LND RPC, and we'd hard-code certain values like
Private: true.With this PR we're forwarding the request as it was given to lndclient, without changing any of its body.